Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Golang version in Makefile to prevent cbuild failure #161

Merged

Conversation

Akash-Nayak
Copy link
Contributor

Fixes: #160

Signed-off-by: Akash Nayak akash19nayak@gmail.com

Signed-off-by: Akash Nayak <akash19nayak@gmail.com>
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the fix label Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.48%. Comparing base (09e78d0) to head (dde38e5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #161   +/-   ##
=======================================
  Coverage   14.48%   14.48%           
=======================================
  Files           2        2           
  Lines         214      214           
=======================================
  Hits           31       31           
  Misses        179      179           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kmehant kmehant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Akash Nayak <akash19nayak@gmail.com>
@Akash-Nayak
Copy link
Contributor Author

@Akash-Nayak Can you also bump up the version on README?

https://github.com/konveyor/move2kube-api/blob/main/README.md?plain=1#L24

Thanks @kmehant ! Done.

Copy link
Contributor

@HarikrishnanBalagopal HarikrishnanBalagopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HarikrishnanBalagopal HarikrishnanBalagopal merged commit 294f95a into konveyor:main Mar 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make cbuild is failing with Go 1.18
3 participants